-
Notifications
You must be signed in to change notification settings - Fork 2
Fix paths and do not copy tests on image #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
073c036
ca08adf
ff4a334
add67f7
fdba243
8a425cf
8423610
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
| node_modules/ | ||
| node_modules_mac/ | ||
| node_modules_cont/ | ||
| package-lock.json | ||
|
|
||
| # Build outputs | ||
| dist/ | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||||||||||||||||||||||
| import { Router, type Request, type Response } from "express"; | ||||||||||||||||||||||||||
| import { z } from "zod"; | ||||||||||||||||||||||||||
| import { BoltService } from "../bolt/BoltService"; | ||||||||||||||||||||||||||
| import { ExecutionRepository } from "../database/ExecutionRepository"; | ||||||||||||||||||||||||||
| import type { BoltService } from "../bolt/BoltService"; | ||||||||||||||||||||||||||
| import type { ExecutionRepository } from "../database/ExecutionRepository"; | ||||||||||||||||||||||||||
| import { asyncHandler } from "./asyncHandler"; | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| /** | ||||||||||||||||||||||||||
|
|
@@ -42,7 +42,7 @@ | |||||||||||||||||||||||||
| boltService: BoltService, | ||||||||||||||||||||||||||
| executionRepository: ExecutionRepository, | ||||||||||||||||||||||||||
| packageTasks: PackageTaskConfig[], | ||||||||||||||||||||||||||
| streamingManager?: import("../services/StreamingExecutionManager").StreamingExecutionManager, | ||||||||||||||||||||||||||
| ): Router { | ||||||||||||||||||||||||||
| const router = Router(); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
@@ -111,9 +111,9 @@ | |||||||||||||||||||||||||
| try { | ||||||||||||||||||||||||||
| // Set up streaming callback if expert mode is enabled and streaming manager is available | ||||||||||||||||||||||||||
| const streamingCallback = expertMode && streamingManager ? { | ||||||||||||||||||||||||||
| onCommand: (cmd: string) => streamingManager.emitCommand(executionId, cmd), | ||||||||||||||||||||||||||
| onStdout: (chunk: string) => streamingManager.emitStdout(executionId, chunk), | ||||||||||||||||||||||||||
| onStderr: (chunk: string) => streamingManager.emitStderr(executionId, chunk), | ||||||||||||||||||||||||||
| onCommand: (cmd: string) => { streamingManager.emitCommand(executionId, cmd); }, | ||||||||||||||||||||||||||
| onStdout: (chunk: string) => { streamingManager.emitStdout(executionId, chunk); }, | ||||||||||||||||||||||||||
| onStderr: (chunk: string) => { streamingManager.emitStderr(executionId, chunk); }, | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
| onCommand: (cmd: string) => { streamingManager.emitCommand(executionId, cmd); }, | |
| onStdout: (chunk: string) => { streamingManager.emitStdout(executionId, chunk); }, | |
| onStderr: (chunk: string) => { streamingManager.emitStderr(executionId, chunk); }, | |
| onCommand: (cmd: string): void => { | |
| streamingManager.emitCommand(executionId, cmd); | |
| }, | |
| onStdout: (chunk: string): void => { | |
| streamingManager.emitStdout(executionId, chunk); | |
| }, | |
| onStderr: (chunk: string): void => { | |
| streamingManager.emitStderr(executionId, chunk); | |
| }, |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -86,9 +86,9 @@ export function createPuppetRouter( | |||||||||||||||||||||||||
| try { | ||||||||||||||||||||||||||
| // Set up streaming callback if expert mode is enabled and streaming manager is available | ||||||||||||||||||||||||||
| const streamingCallback = expertMode && streamingManager ? { | ||||||||||||||||||||||||||
| onCommand: (cmd: string) => streamingManager.emitCommand(executionId, cmd), | ||||||||||||||||||||||||||
| onStdout: (chunk: string) => streamingManager.emitStdout(executionId, chunk), | ||||||||||||||||||||||||||
| onStderr: (chunk: string) => streamingManager.emitStderr(executionId, chunk), | ||||||||||||||||||||||||||
| onCommand: (cmd: string) => { streamingManager.emitCommand(executionId, cmd); }, | ||||||||||||||||||||||||||
| onStdout: (chunk: string) => { streamingManager.emitStdout(executionId, chunk); }, | ||||||||||||||||||||||||||
| onStderr: (chunk: string) => { streamingManager.emitStderr(executionId, chunk); }, | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
| onCommand: (cmd: string) => { streamingManager.emitCommand(executionId, cmd); }, | |
| onStdout: (chunk: string) => { streamingManager.emitStdout(executionId, chunk); }, | |
| onStderr: (chunk: string) => { streamingManager.emitStderr(executionId, chunk); }, | |
| onCommand: (cmd: string): void => { | |
| streamingManager.emitCommand(executionId, cmd); | |
| }, | |
| onStdout: (chunk: string): void => { | |
| streamingManager.emitStdout(executionId, chunk); | |
| }, | |
| onStderr: (chunk: string): void => { | |
| streamingManager.emitStderr(executionId, chunk); | |
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent arrow function syntax for streaming callbacks. In
tasks.ts, the callbacks use explicit return type annotations and are formatted across multiple lines (e.g.,onCommand: (cmd: string): void => { ... }), while in this file they're inline with braces but no return type. Consider standardizing the pattern across all route files for consistency.