Update the Julia interface of ColPack#30
Conversation
gdalle
left a comment
There was a problem hiding this comment.
Looks good to me, I presume the timer tests are deactivated because timers are not initialized?
Can we add some tests for the new ordering retrieval, then this should be good to go?
|
Once this is merged we could do a new release of ColPack.jl? If I understand correctly, we now go through the |
|
The format |
|
At the beginning of #21 we had also found a case where the binary was deterministic but the coloring through CSR/CSC was random, that's what I was referring to here |
OpenMP. It seems to fix the non-determinism.orderandmethodin the C++ code like"NAIVE_STAR"or"DYNAMIC_LARGEST_FIRST".Timersuch that it works and that we have highly accurate timers directly from ColPack for the ordering and coloring.libcolpack.jlfrom the headercinterface.hif the C interface of ColPack is updated.coloringandordering.Comments:
LARGEST_FIRSTreturns invalid ordering that is not a permutation is some rare cases. The methodTRIANGULARfails with segmentation fault.The ADOLC reader was not modified by my commits.
The CSR should work but it was buggy before and I fixed it, so for the current paper it is more relevant to use as much as possible things not added by me in the C++ code (ADOLC format / MTX files).