Skip to content

Conversation

@ArBridgeman
Copy link
Collaborator

Closes #399

@ArBridgeman
Copy link
Collaborator Author

ArBridgeman commented Apr 9, 2025

Before this can be merged, we should try to ensure project-keeper has been updated:
cp: https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/dependencies_check.yml#L46
In this case 1.0.0 has already been released, but given the usual order of operations (prepare release -- where the version is updated & then tag, which has variable times between), & the usage of @main, this would cause issues for the project-keeper. However, in general, github actions should be pinned to a version & not main.

@ArBridgeman
Copy link
Collaborator Author

ArBridgeman commented Apr 9, 2025

Before this can be merged, we should try to ensure project-keeper has been updated: cp: https://github.com/exasol/project-keeper/blob/main/project-keeper/src/main/resources/templates/.github/workflows/dependencies_check.yml#L46 In this case 1.0.0 has already been released, but given the usual order of operations (prepare release -- where the version is updated & then tag, which has variable times between), & the usage of @main, this would cause issues for the project-keeper. However, in general, github actions should be pinned to a version & not main.

Discussed how would proceed & made exasol/project-keeper#641

@ArBridgeman ArBridgeman force-pushed the refactoring/399_ensure_all_ptb_versions_updated branch from d557c1d to 747732a Compare April 9, 2025 11:20
tomuben
tomuben previously approved these changes Apr 10, 2025
@ArBridgeman ArBridgeman merged commit 7a08471 into main Apr 11, 2025
33 checks passed
@ArBridgeman ArBridgeman deleted the refactoring/399_ensure_all_ptb_versions_updated branch April 11, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔧 Update PTB versions in GitHub actions

4 participants