Feature/382 clean up for nox task dependency changes #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ArBridgeman merged 18 commits into main from feature/382_clean_up_for_nox_task_dependency_changes

May 28, 2025

Collaborator

ArBridgeman commented May 23, 2025 •

edited

Loading

closes #449

ArBridgeman added 10 commits

May 22, 2025 13:02


          Remove tool.poetry.dev.dependencies from nox task `dependency:licen…

61d1add

…ses` as not poetry 2.x+ compatible


          Get groups for direct dependencies from pyproject.toml

11c8bce


          Extract all dependencies from poetry show to divide into direct & tra…

0e046b4

…nsitive


          Use updated pydantic models in license code

dc25568


          Split up licenses and shared model to appropriate test and files

0cd5a68


          Move some of the mappings to be used in the pydantic model

ffddc59


          Add pydantic to main dependencies

e4faf1e


          Add entry to changelog for modifications

14e306b


          Update to pyupgrades to 3.9 but skip typing changes as incorrectly pu…

41eba1a

…tting Optional[str], etc. to str | None for python3.9 and fix linting issues

* afaics there is not an inline skip message


          Make versions more explicit in test

a92c6fd

ArBridgeman commented

View reviewed changes

test/unit/util/dependencies/poetry_dependencies_test.py Show resolved Hide resolved

ArBridgeman commented

View reviewed changes

exasol/toolbox/util/dependencies/poetry_dependencies.py Show resolved Hide resolved

ArBridgeman commented

View reviewed changes

exasol/toolbox/nox/_format.py Outdated Show resolved Hide resolved

ArBridgeman commented

View reviewed changes

exasol/toolbox/util/dependencies/licenses.py Show resolved Hide resolved

ArBridgeman commented

View reviewed changes

exasol/toolbox/util/dependencies/poetry_dependencies.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

doc/changes/unreleased.md Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

doc/changes/unreleased.md Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/licenses.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/licenses.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/licenses.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/poetry_dependencies.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/poetry_dependencies.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/licenses.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/poetry_dependencies.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

exasol/toolbox/util/dependencies/shared_models.py Outdated Show resolved Hide resolved

ArBridgeman added 5 commits

May 27, 2025 10:54


          Use created issued and fix changelog to better reflect that this is a…

07e1c0a

… refactored change


          Resolve pydantic python3.9 type issues in a more configurable way

9d56fc9


          Fix type & check as mentioned in review comments

b8385c3


          Remove unneeded poetry run from nox task usage

2a164b6


          Use Package instead of PoetryDependency, as group info already given,…

4f39517

… which makes for easier comparisons

ArBridgeman added 2 commits

May 27, 2025 14:06


          Switch version in Package to Version with conversion from string

46233bc

and add pydantic to mypy plugins


          Switch loading of content to be explicit so clearer

1cc7ba7

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:18

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:18

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:18

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:18

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:18

— with

GitHub Actions Inactive


          Put break back in correct spot

2ca95be

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:23

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:23

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:23

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:23

— with

GitHub Actions Inactive

ArBridgeman temporarily deployed to manual-approval

May 27, 2025 13:23

— with

GitHub Actions Inactive

Collaborator Author

ArBridgeman commented May 27, 2025

Added #450 as would also use need updated toml parsing, but as this PR is already rather large, didn't want to add more on.

ArBridgeman requested review from tkilias and tomuben

May 27, 2025 13:23

tomuben approved these changes

View reviewed changes

ArBridgeman merged commit 65069f1 into main

33 checks passed

ArBridgeman deleted the feature/382_clean_up_for_nox_task_dependency_changes branch

May 28, 2025 06:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet