Skip to content

Conversation

@jaladh-singhal
Copy link
Contributor

Fixes #678 - I implemented a mix of both approaches mentioned there (because I couldn't resist noticing more unpolished dark-mode coloring as I delved into it 🧐)

  • Updated .cell_output styles to remove borders from plain or stream outputs that contain highlighted blocks (I realized we want to keep borders for traceback and stderr so left them untouched)
  • Introduced neutral and danger color palettes (based on Material Design palette generator), replacing hardcoded colors with palette variables for logical and consistent use of colors.
    • Added dark theme overrides for uniform look.

@jaladh-singhal
Copy link
Contributor Author

jaladh-singhal commented Jul 2, 2025

For testing: Compare https://myst-nb--679.org.readthedocs.build/en/679/authoring/jupyter-notebooks.html#code-cells-and-outputs with https://myst-nb.readthedocs.io/en/latest/authoring/jupyter-notebooks.html#code-cells-and-outputs in dark mode.

Note how dark mode red border for traceback cell output is darker red shade as it should be in dark theme (unlike a light red shade in light theme)

Also regression test light mode, since I tweaked colors a lil bit to follow the palette.

@bsipocz bsipocz added the bug Something isn't working label Jul 2, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable to me, and the diff is clearly an improvement so I'm going ahead and merge this now. Thanks @jaladh-singhal!

@bsipocz bsipocz merged commit fc73430 into executablebooks:master Jul 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output cells in dark mode are hard to distinguish from input cells, unlike light mode

2 participants