Skip to content

First Release#4

Merged
jimmytty merged 28 commits intoexercism:masterfrom
jimmytty:first-release
Nov 7, 2025
Merged

First Release#4
jimmytty merged 28 commits intoexercism:masterfrom
jimmytty:first-release

Conversation

@jimmytty
Copy link
Contributor

@jimmytty jimmytty commented Nov 5, 2025

This first release uses alpine as docker image and I have added three more tests.

Both ./bin/run-tests.sh and ./bin/run-tests-in-docker.sh executes successfully.

@jimmytty jimmytty requested a review from a team as a code owner November 5, 2025 02:59
Copy link
Member

@IsaacG IsaacG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot going on...

jimmytty and others added 8 commits November 5, 2025 09:29
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
jimmytty and others added 8 commits November 6, 2025 16:06
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
jimmytty and others added 3 commits November 6, 2025 18:48
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
Co-authored-by: Glenn Jackman <glenn.jackman@gmail.com>
@glennj glennj added the x:rep/massive Massive amount of reputation label Nov 6, 2025
@glennj
Copy link
Contributor

glennj commented Nov 6, 2025

I'm assuming that it all works, and the tests pass. Next step (next PR) is to add the GitHub workflows.

@glennj
Copy link
Contributor

glennj commented Nov 6, 2025

One tip for the track repo: there are a few "constant" files for each exercise. Add those to a "lib" or "assets" directory that can be used when you're creating new exercises. Or if you need to change one of them, do it in the asset dir then a little script can be used to deploy to all exercises.

@jimmytty jimmytty merged commit b26aad0 into exercism:master Nov 7, 2025
@jimmytty jimmytty deleted the first-release branch November 7, 2025 03:33
@jimmytty
Copy link
Contributor Author

jimmytty commented Nov 7, 2025

I'm assuming that it all works, and the tests pass. Next step (next PR) is to add the GitHub workflows.

The workflows are something that repo admins will do and I'll need to wait or is something I need to do? I have checked "tap" test-renners and I didn't see real need to modifications (perhaps because my lack of experience).

@glennj
Copy link
Contributor

glennj commented Nov 8, 2025

You can just copy them from the generic-test-runner: https://github.com/exercism/generic-test-runner/tree/main/.github/workflows

@exercism/maintainers-admin is that right?

@jimmytty
Copy link
Contributor Author

jimmytty commented Nov 8, 2025

You can just copy them from the generic-test-runner: https://github.com/exercism/generic-test-runner/tree/main/.github/workflows

The only modification was to the ci.yml file, which had some hashes updated. (Now I understand why I wasn't seeing anything different.)

@exercism/maintainers-admin is that right?
I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:rep/massive Massive amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants