Tidy some of the bash scripts

[IsaacG]

No description provided.

[glennj]

On second thought, xargs might be better:

Suggested change

	mapfile -t files < <(git grep --files-with-matches replace-this-with-the-track-slug)
	sed -i "s/replace-this-with-the-track-slug/${SLUG}/g" "${files[@]}"
	git grep --null --files-with-matches replace-this-with-the-track-slug) \
	| xargs --null sed -i "s/replace-this-with-the-track-slug/${SLUG}/g"

[IsaacG]

I'm not generally a huge fan of xargs. Is there anything wrong with passing the files to sed? I really don't think we need to protect against newlines in the file names here.

[glennj]

and it's very unlikely we'll find thousands of filenames.

[ErikSchierboom]

I've tried running the bootstrap script on my Mac (which Jeremy and I both use), and I got:

erik@Eriks-MacBook-Pro-2 generic-test-runner % LANGUAGE=Fake SLUG=fake bin/bootstrap.sh
bin/bootstrap.sh: line 42: mapfile: command not found

[IsaacG]

I've tried running the bootstrap script on my Mac (which Jeremy and I both use), and I got:

erik@Eriks-MacBook-Pro-2 generic-test-runner % LANGUAGE=Fake SLUG=fake bin/bootstrap.sh
bin/bootstrap.sh: line 42: mapfile: command not found

mapfile was added to bash 4.4 in 2016. The "default" bash on Mac is pinned to bash 3 (2005).

Is bash 3 the target shell here? What about the Docker scripts -- should those target POSIX sh? Or can those target modern bash if they run on a modern Linux image?

[glennj]

Working on a Mac, we'll also have trouble with sed -i that requires an argument on the BSD-ish Mac sed.

We do need to establish a baseline set of tools.

[ErikSchierboom]

Working on a Mac, we'll also have trouble with sed -i that requires an argument on the BSD-ish Mac sed.
We do need to establish a baseline set of tools.

Anything that maintainers like Jeremy and I use must work on Macs. The scripts that run in Docker images can likely use more modern version of bash. 95% of the time, the base Docker image that people use is Alpine or Ubuntu. If we can target the scripts to run there, we'll be fine.

[glennj]

Working on a Mac, we'll also have trouble with sed -i that requires an argument on the BSD-ish Mac sed.
We do need to establish a baseline set of tools.

Anything that maintainers like Jeremy and I use must work on Macs. The scripts that run in Docker images can likely use more modern version of bash. 95% of the time, the base Docker image that people use is Alpine or Ubuntu. If we can target the scripts to run there, we'll be fine.

@ErikSchierboom are you OK being told to go install a modern bash from homebrew?

@IsaacG we can just replace sed with perl, it's installed everywhere.

perl -i "s/replace-this-with-the-track-slug/${SLUG}/g" "${files[@]}"

[ErikSchierboom]

I'm fine with that if Jeremy is too

[IsaacG]

Sounds like we need input from @iHiD here :)

I haven't written Perl in about a decade and I'm not a fan but we can totally swap sed for perl if that's more compatible!

[IsaacG]

@ErikSchierboom Any last thoughts before merging?

[glennj]

A thought about mapfile and bash 3.2 on the Mac: we can add a check into the script for the minimum required version:

if (( "${BASH_VERSINFO[0]}${BASH_VERSINFO[1]}" < 44 )); then
    echo "This script requires bash version 4.4 at minimum." >&2
    echo "You can install a modern bash from Homebrew - https://brew.sh" >&2
    exit 1
fi

[ErikSchierboom]

@ErikSchierboom Any last thoughts before merging?

I need to test that it works :)

[ErikSchierboom]

One last suggestion and then we're good