Add practice exercise rational-numbers#248
Open
natanaelsirqueira wants to merge 8 commits intoexercism:mainfrom
Open
Add practice exercise rational-numbers#248natanaelsirqueira wants to merge 8 commits intoexercism:mainfrom
rational-numbers#248natanaelsirqueira wants to merge 8 commits intoexercism:mainfrom
Conversation
jiegillet
reviewed
Mar 1, 2023
Contributor
jiegillet
left a comment
jiegillet
left a comment
There was a problem hiding this comment.
Nice work! Let's iron out some wrinkles :)
exercises/practice/rational-numbers/test/rational_numbers_test.gleam
Outdated
Show resolved
Hide resolved
| pub fn power_of_real( | ||
| number base: Int, | ||
| to exponent: RationalNumber, | ||
| ) -> Result(Float, Nil) { |
Contributor
There was a problem hiding this comment.
It feels strange to have a Result here but no test with an error case...
What do you think?
Maybe we should add a test case with a negative base to the problem-specs?
Contributor
Author
There was a problem hiding this comment.
Sounds good. I'll work on a PR later today.
Contributor
Author
There was a problem hiding this comment.
Opened the PR and it got closed as expected. Are you able to reopen?
Contributor
There was a problem hiding this comment.
Thank you. Let's wait for the PR to be merged before merging this one :)
natanaelsirqueira
force-pushed
the
add-exercise-rational-numbers
branch
from
ae9102f to
15b9ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.