Conversation
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Wonderful! One small note inline
config.json
Outdated
| "practices": [], | ||
| "prerequisites": [], |
There was a problem hiding this comment.
We'll need to have some practices and prerequisites here!
| import gleam/dict.{type Dict} | ||
| import gleam/list | ||
| import gleam/option.{type Option, None, Some} | ||
| import gleam/otp/task |
There was a problem hiding this comment.
This hasn't been taught yet by this point, and it's an indirect dependency so it'll emit a warning.
It would be best if the concept of an OTP task had been taught prior to having the student use it.
There was a problem hiding this comment.
I noticed the CI build failed as I had added the OTP task to the prerequisite, although it hasn't been added yet. I've since it removed it and raised #454.
config.json
Outdated
| "lists" | ||
| ], | ||
| "prerequisites": [ | ||
| "lists" |
There was a problem hiding this comment.
This is missing regex, options, strings, dicts, and OTP tasks.
There was a problem hiding this comment.
Ah I think missed those earlier as I didn't seem them listed in the existing concepts. I've just added them and pushed.
With the dict one, I put maps in its place as I noticed the existing ones called it maps instead of dict and I assumed it would be updated as part #396. Let me know if you'd prefer me to change it to dict instead.
There was a problem hiding this comment.
Update - Nevermind, I just saw pull request #431 and decided to go ahead and update this pull request to use dicts to match.
…el-letter-frequency
This is to match the upcoming changes in PR exercism#431.
…el-letter-frequency
…el-letter-frequency
…el-letter-frequency
…el-letter-frequency
2 participants
Adds the parallel letter frequency for 48in24.