Skip to content

adds explanation about multiple literal patterns#551

Merged
lpil merged 5 commits intoexercism:mainfrom
JP-Go:patch-1
May 14, 2025
Merged

adds explanation about multiple literal patterns#551
lpil merged 5 commits intoexercism:mainfrom
JP-Go:patch-1

Conversation

@JP-Go
Copy link
Contributor

@JP-Go JP-Go commented May 1, 2025

Adds an explanation about multiple literal patterns in case expressions and how guards can be used on them

Adds an explanation about multiple literal patterns in case expressions and how guards can be used on them
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

// No compiler error
```

Multiple __literal patterns__ can be matched in one clause using the `|` to separate between each literal value. Only one guard can be added to a case:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the stuff about literal patterns please, all patterns use literal syntax, and they are not values between the |s

Copy link
Contributor Author

@JP-Go JP-Go May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Changed it. Could you review again?

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

edit: oh hum, tests are failing for some reason. Can you see why?

edit2: Ah, it says "GitHub Actions has encountered an internal error when running your job.". I'm not sure what that means. Could you try pushing another commit and see what that does please

@JP-Go
Copy link
Contributor Author

JP-Go commented May 4, 2025

Nice, thanks!

edit: oh hum, tests are failing for some reason. Can you see why?

edit2: Ah, it says "GitHub Actions has encountered an internal error when running your job.". I'm not sure what that means. Could you try pushing another commit and see what that does please

Sure. I'll push the code again. Sorry for the late response

@JP-Go
Copy link
Contributor Author

JP-Go commented May 4, 2025

@lpil CI pushed a tiny change of wording

@lpil
Copy link
Member

lpil commented May 5, 2025

I think it might be that the runner is out of date. Doing a test here: #552

@lpil
Copy link
Member

lpil commented May 12, 2025

Could you rebase on main please 🙏

@JP-Go
Copy link
Contributor Author

JP-Go commented May 12, 2025

Sure. I'll be sending it up right away

@JP-Go
Copy link
Contributor Author

JP-Go commented May 14, 2025

@lpil Done

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lpil lpil merged commit 6bfca16 into exercism:main May 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants