Remove collection from array description #2843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the description of Java arrays to avoid confusion with the term "collection" as used in the Java Collections Framework. Previously, the text referred to arrays as collections, which is inaccurate in Java's formal terminology. The native Java arrays are not part of the Collections Framework, as they do not implement the `Collection` interface or its subtypes, such as `List`, `Set`, or `Map`. They are simply fixed-size objects that hold elements of the same type. This change helps prevent misunderstanding and aligns the description with Java's official definitions.
kahgoh
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Hi @lcsvoj ! The proposed changes look fine to me and I generally agree with removing the references to "collection" from arrays.
However, there are a couple of other files we should update as they have the same problem. We should be able to copy and paste the proposed change. Could you also update them? They are:
Updated the description of Java arrays to avoid confusion with the term "collection" as used in the Java Collections Framework. Previously, the text referred to arrays as collections, which is inaccurate in Java's formal terminology. The native Java arrays are not part of the Collections Framework, as they do not implement the `Collection` interface or its subtypes, such as `List`, `Set`, or `Map`. They are simply fixed-size objects that hold elements of the same type. This change helps prevent misunderstanding and aligns the description with Java's official definitions.
kahgoh
approved these changes
Nov 6, 2024
kahgoh
changed the title
kahgoh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request
Updated the description of Java arrays to avoid confusion with the term "collection" as used in the Java Collections Framework. Previously, the text referred to arrays as collections, which is inaccurate in Java's formal terminology.
Native Java arrays are not part of the Collections Framework, as they do not implement the
Collectioninterface or its subtypes, such asList,Set, orMap. They are simply fixed-size objects that hold elements of the same type.I have rephrased the description to make it more accessible for those who are new to Java, avoiding excessive technical jargon while still preventing misunderstandings and aligning the explanation with Java's official definitions.
Reviewer Resources:
Track Policies