Skip to content

Remove multiply and divide methods accepting double from ComplexNumbe… #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Remove multiply and divide methods accepting double from ComplexNumbe… #2852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
903cdbf
Remove multiply and divide methods accepting double from ComplexNumbe…
jagdish-15 Nov 2, 2024
67924cf
Editing reference answer to fit the CheckStyle error
jagdish-15 Nov 2, 2024
aff1749
Editing reference answer to fix CheckStyle error
jagdish-15 Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions exercises/practice/complex-numbers/.meta/src/reference/java/ComplexNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
final class ComplexNumber {

private final double real;

private final double imaginary;

ComplexNumber(double real, double imaginary) {
Expand Down Expand Up @@ -32,7 +31,10 @@ ComplexNumber subtract(ComplexNumber other) {
}

ComplexNumber divide(ComplexNumber other) {
return this.multiply(other.conjugate()).divide(Math.pow(other.abs(), 2));
double divisor = Math.pow(other.real, 2) + Math.pow(other.imaginary, 2);
return new ComplexNumber(
(real * other.real + imaginary * other.imaginary) / divisor,
(imaginary * other.real - real * other.imaginary) / divisor);
}

double abs() {
Expand All @@ -44,14 +46,6 @@ ComplexNumber conjugate() {
}

ComplexNumber exponentialOf() {
return new ComplexNumber(Math.cos(imaginary), Math.sin(imaginary)).multiply(Math.exp(real));
}

private ComplexNumber divide(double factor) {
return new ComplexNumber(real / factor, imaginary / factor);
}

private ComplexNumber multiply(double factor) {
return new ComplexNumber(factor * real, factor * imaginary);
return new ComplexNumber(Math.exp(real) * Math.cos(imaginary), Math.exp(real) * Math.sin(imaginary));
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make check that there is an empty line at the end? Without it, Checkstyle fails.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do it right now!

9 changes: 0 additions & 9 deletions exercises/practice/complex-numbers/src/main/java/ComplexNumber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,15 @@ ComplexNumber multiply(ComplexNumber other) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber multiply(double factor) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber divide(ComplexNumber other) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber divide(double divisor) {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber conjugate() {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

ComplexNumber exponentialOf() {
throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
}

}
Loading