Fix grammar and clarity in reference types explanation #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahgoh
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks for pointing out those errors and submitting a PR to fix them! I have a couple minor suggestions.
In addition, could you also update concepts/nullability/introduction.md and concepts/nullability/about.md? They have a similar problem.
Co-authored-by: Kah Goh <[email protected]>
Co-authored-by: Kah Goh <[email protected]>
|
@kahgoh Thank you for the comments have implemented your suggestions in all the files. |
kahgoh
reviewed
Nov 7, 2024
Co-authored-by: Kah Goh <[email protected]>
kahgoh
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request
Small change to the grammar to make more sense.
Reviewer Resources:
Track Policies