Skip to content

Write constants in UPPER_CASE #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Write constants in UPPER_CASE #2884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions exercises/practice/darts/.approaches/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,19 @@ import java.util.function.DoublePredicate;

class Darts {

final private static double innerRing = 1.0;
final private static double middleRing = 5.0;
final private static double outerRing = 10.0;
private static final double INNER_RING = 1.0;
private static final double MIDDLE_RING = 5.0;
private static final double OUTER_RING = 10.0;

int score(double x, double y) {
var pointRadius = (Math.sqrt((x * x) + (y * y)));
DoublePredicate thrownOutside = ring -> pointRadius > ring;

if (thrownOutside.test(outerRing))
if (thrownOutside.test(OUTER_RING))
return 0;
if (thrownOutside.test(middleRing))
if (thrownOutside.test(MIDDLE_RING))
return 1;
if (thrownOutside.test(innerRing))
if (thrownOutside.test(INNER_RING))
return 5;
return 10;
}
Expand Down