Skip to content

Conversation

stamatisn
Copy link

@stamatisn stamatisn commented Dec 28, 2024

Fixes (#2823)
Now the testRaiseARealNumberToAPositiveRationalNumber() test gets passed.

pull request


Reviewer Resources:

Track Policies

Fixed the bug in (#2823) issue
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@stamatisn
Copy link
Author

Fixed bug (#2823) Now the testRaiseARealNumberToAPositiveRationalNumber() test gets passed.
no important files changed

pull request

Reviewer Resources:

Track Policies

@kahgoh kahgoh self-requested a review December 30, 2024 09:39

private void assertDoublesEqual(double x, double y) {
assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the AssertJ examples, I was wondering if this is what you meant?

Suggested change
assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));
assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE));

Otherwise this doesn't compile:

/home/runner/work/java/java/exercises/practice/rational-numbers/src/test/java/RationalTest.java:14: error: ')' expected
> Task :practice:rational-numbers:compileStarterSourceJava
        assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));

@stamatisn stamatisn closed this Dec 30, 2024
@stamatisn stamatisn reopened this Dec 30, 2024
@stamatisn
Copy link
Author

Yes this is what I meant to write. I opened another pull request (#2887) and I uploaded the corrected code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants