Skip to content

Correct UK dialing code and fix typo in the International Calling Connoisseur instructions #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Correct UK dialing code and fix typo in the International Calling Connoisseur instructions #2925

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43a34cd
Correct UK dialing code and fix typo in the International Calling Con…
rkabhishek Mar 12, 2025
8e18504
Fix the UK dialing code in the tests as well
rkabhishek Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/concept/international-calling-connoisseur/.docs/instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ dialingCodes.addNewDialingCode(39, "Vatican City");

Its rare, but mistakes can be made.
To correct the mistake, we will need to know what dialing code the country is currently mapped to.
To find which dialing code needs to be corrected, implement the `findDialingCode` method that takes in a map of dialing codes an a country and returns the country's dialing code.
To find which dialing code needs to be corrected, implement the `findDialingCode` method that takes in a map of dialing codes and a country and returns the country's dialing code.
Return `null` if the country is _not_ in the map.

```java
DialingCodes dialingCodes = new DialingCodes();
dialingCodes.addDialingCode(43, "UK");
dialingCodes.addDialingCode(44, "UK");
dialingCodes.findDialingCode("UK");
// => 44

Expand Down