Skip to content

Conversation

@jagdish-15
Copy link
Member

@jagdish-15 jagdish-15 commented Jun 5, 2025

Pull Request

This PR updates 18 instances of generic link text across 10 files to resolve markdown linting errors introduced by recent markdownlint rule upgrades (via Dependabot).


Reviewer Resources:

Track Policies

@jagdish-15 jagdish-15 mentioned this pull request Jun 5, 2025
@jagdish-15
Copy link
Member Author

jagdish-15 commented Jun 5, 2025

@kahgoh

There are probably 2 places where I've done something like in [this](link) and [this](link) article, lemme know if it'd better be in [this article](link) and [this article](link)

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR to fix the new linting errors! I have some minor suggestions below 👇🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this file as it was. The instructions are synced from the problem specifications and there is already a PR to fix this in the problem specifications. There is also a related forum post.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a PR for this in the problem-specifications repo's PR page. Also, when I open the link you shared, it leads to a page like this:

Screenshot 2025-06-06 180141

Am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops, I copied the link from the repository and totally missed that it is just a diff 😅.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I didn't see any PR with this change. Are you sure the PR is raised?

@jagdish-15
Copy link
Member Author

I've committed all the suggested changes. The only remaining linting error is due to instructions.md, but that would be addressed first in the problem-specifications repo, right?

@kahgoh
Copy link
Member

kahgoh commented Jun 6, 2025

I've committed all the suggested changes. The only remaining linting error is due to instructions.md, but that would be addressed first in the problem-specifications repo, right?

Yes, I think that should be addressed at the problem specs repo.

@kahgoh kahgoh merged commit 276d466 into exercism:main Jun 7, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants