Skip to content

Conversation

zamora-carlos
Copy link
Contributor

pull request

Add Piecing It Together practice exercise based on the instructions detailed here.

In the config.json file, I included exceptions, for-loops, and if-else-statements as prerequisites. I wasn’t sure whether to add them to the practices array as well, since most exercises seem to leave it empty.

I’ve read the contribution guidelines, but please let me know if I’ve missed anything.

Closes #2949


Reviewer Resources:

Track Policies

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a great start!

In the config.json file, I included exceptions, for-loops, and if-else-statements as prerequisites. I wasn’t sure whether to add them to the practices array as well, since most exercises seem to leave it empty.

Leaving the practices array empty is fine!

The only thing missing is the gradle directory. You should simply be able to copy the contents from another exercise, like change (this is needed for students to run ./gradlew properly).

@zamora-carlos
Copy link
Contributor Author

Hello, thank you for your detailed comments! I’ve made the requested changes. I just have one question: I currently placed the JigsawInfo class (previously PartialJigsawInformation) in both .meta/src/reference/java and src/main/java. Is that okay, or was it only needed in the reference folder?

@zamora-carlos zamora-carlos requested a review from kahgoh June 22, 2025 22:54
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently placed the JigsawInfo class (previously PartialJigsawInformation) in both .meta/src/reference/java and src/main/java. Is that okay, or was it only needed in the reference folder?

Yes, that's fine! In fact, that's currently needed for the CI tests to pass.

@zamora-carlos
Copy link
Contributor Author

Hi, I’ve updated the builder in the JigsawInfo class and fixed the style issues. The code now passes the verification check. Please let me know if any additional changes are needed.

@zamora-carlos zamora-carlos requested a review from kahgoh June 23, 2025 19:00
@zamora-carlos zamora-carlos requested a review from kahgoh June 25, 2025 20:00
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kahgoh kahgoh merged commit fac4620 into exercism:main Jun 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add piecing it together exercise

2 participants