Skip to content

Conversation

@jelambrar96
Copy link

📌 Pull Request: Add new test case for "orange, orange, red" resistor combination

Summary:

This PR adds a new unit test to the ResistorColorTrioTest class to validate the correct label generation for the resistor color combination {"orange", "orange", "red"}.

Details:

  • Added test method: testOrangeAndOrangeAndRed
  • Expected result: "3.3 kiloohms"
  • The test is currently annotated with @Disabled to maintain consistency with other pre-disabled test cases in this suite.
  • This allows contributors or students to manually enable and verify the test once the corresponding functionality is implemented or updated.

Why this is useful:

  • Improves test coverage for the resistor color combinations.
  • Helps validate handling of multiplier values when the third band leads to decimal kiloohm values.

Next steps:

  • Remove @Disabled once the implementation is ready.
  • Confirm that the output matches "3.3 kiloohms" as per spec.

Reviewer Resources:

Track Policies

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jelambrar96!

Here at Exercism, all tests are synced from a central problem-specifications repository, which is shared across all language tracks.

If you have an idea for adding or changing a test, we recommend first sharing it in our forum to get feedback and approval. Once it's approved there, you can raise a PR in the problem-specifications repo. Only after that can the change be incorporated into the individual language tracks.

@jagdish-15 jagdish-15 closed this Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants