Skip to content

Conversation

Arsh0388
Copy link

pull request

I have added the @DisplayName Annotation to 3 test files i.e ZipperTest, ZebraPuzzleTest and YachtTest. All the checks have passed and tests have been passed on my machine.


Reviewer Resources:

Track Policies

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Arsh0388
Copy link
Author

Arsh0388 commented Aug 26, 2025

I have received an email stating that the pr touches the files hwich potentially affects the outcome of the tests of an excercise. But I have looked at those and it's just indentation change caused by my ide by default. Besides that there are no issues.

Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notice appears whenever a PR modifies test files. Since we’re not changing the test data itself, you can safely ignore it.

Also, please remove the extra indentation added by your IDE. You can adjust this in your IDE settings so that the formatting stays consistent.

Lastly, make the suggested changes.

Comment on lines 2 to +5
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;
import org.junit.jupiter.api.DisplayName;
Copy link
Member

@jagdish-15 jagdish-15 Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;

Comment on lines 3 to +6
import org.junit.jupiter.api.BeforeEach;

import static org.assertj.core.api.Assertions.assertThat;
import org.junit.jupiter.api.DisplayName;
Copy link
Member

@jagdish-15 jagdish-15 Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure all org.junit.jupiter.api.___ imports are grouped together.
Also, please move import org.junit.jupiter.api.BeforeEach; to the top so the imports follow alphabetical order.

See the suggested changes for example, and apply the same rule to the third file as well, keeping imports neatly sorted alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants