-
-
Notifications
You must be signed in to change notification settings - Fork 735
Completed with adding @DisplayName to bank-account, binary-search-tree, binary-search, bob, book-store #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've listed some changes!
|
||
@Disabled("Remove to run test") | ||
@Test | ||
@DisplayName("") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing one here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with all the changes.
Co-authored-by: Jagdish Prajapati <[email protected]>
Co-authored-by: Jagdish Prajapati <[email protected]>
Can you please suggest something to take care of the checkstyle error? |
Co-authored-by: Jagdish Prajapati <[email protected]>
pull request
I noticed an inconsistency between the Canonical-data and the tests, and I've made the changes on line no. 164 in exercise bank account.
Reviewer Resources:
Track Policies