-
-
Notifications
You must be signed in to change notification settings - Fork 731
Add displayname annotations #2971 #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add displayname annotations #2971 #3029
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the following changes:
exercises/practice/simple-cipher/src/test/java/SimpleCipherTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/simple-cipher/src/test/java/SimpleCipherTest.java
Outdated
Show resolved
Hide resolved
@DisplayName("nine hundred eighty-seven billion six hundred " + | ||
"fifty-four\nmillion three hundred twenty-one thousand one hundred twenty-three") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DisplayName("nine hundred eighty-seven billion six hundred " + | |
"fifty-four\nmillion three hundred twenty-one thousand one hundred twenty-three") | |
@DisplayName("a big number") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kahgoh
These are the tests that weren’t part of the canonical data. Do you have any nits or suggestions for the descriptions?
@bibekparajuli123
You can make the changes after Kah shares his thoughts on this.
exercises/practice/secret-handshake/src/test/java/HandshakeCalculatorTest.java
Show resolved
Hide resolved
1d92d80
to
6c55b7f
Compare
Thanks for correcting me, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly click on Commit suggestion
or Add suggestion to batch
to address these. It'll be better than making a commit locally and then pushing it!
You missed one and slightly misinterpreted another earlier, so this way it's simpler and avoids that.
exercises/practice/simple-cipher/src/test/java/SimpleCipherTest.java
Outdated
Show resolved
Hide resolved
…t.java simple-cipher-changes Co-authored-by: Jagdish Prajapati <[email protected]>
pull request
Add DisplayName annotations to multiple modules
This merge includes the addition of DisplayName annotations to the following exercises:
Reviewer Resources:
Track Policies