Skip to content

Conversation

bibekparajuli123
Copy link
Contributor

pull request

Add DisplayName annotations to multiple modules

This merge includes the addition of DisplayName annotations to the following exercises:

  • state-of-tic-tac-toe
  • spiral-matrix
  • space-age
  • simple-cipher
  • sieve
  • sgf-parsing
  • series
  • secret-handshake
  • scrabble-score
  • say
  • satellite
  • saddle-points

Reviewer Resources:

Track Policies

Copy link
Contributor

github-actions bot commented Oct 4, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the following changes:

Comment on lines 124 to 125
@DisplayName("nine hundred eighty-seven billion six hundred " +
"fifty-four\nmillion three hundred twenty-one thousand one hundred twenty-three")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@DisplayName("nine hundred eighty-seven billion six hundred " +
"fifty-four\nmillion three hundred twenty-one thousand one hundred twenty-three")
@DisplayName("a big number")

Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahgoh
These are the tests that weren’t part of the canonical data. Do you have any nits or suggestions for the descriptions?

@bibekparajuli123
You can make the changes after Kah shares his thoughts on this.

@bibekparajuli123 bibekparajuli123 force-pushed the add-displayname-annotations branch from 1d92d80 to 6c55b7f Compare October 7, 2025 13:23
@bibekparajuli123
Copy link
Contributor Author

Thanks for correcting me, please review

Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly click on Commit suggestion or Add suggestion to batch to address these. It'll be better than making a commit locally and then pushing it!

You missed one and slightly misinterpreted another earlier, so this way it's simpler and avoids that.

@jagdish-15 jagdish-15 merged commit 2d7ca51 into exercism:main Oct 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants