Skip to content

Update ISBN verifier #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Update ISBN verifier #3042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fde464
Update ISBN verifier
kahgoh Oct 31, 2025
d0d6189
Merge branch 'main' into update/isbn-verifier
jagdish-15 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions exercises/practice/isbn-verifier/.meta/tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ description = "invalid character in isbn is not treated as zero"
[28025280-2c39-4092-9719-f3234b89c627]
description = "X is only valid as a check digit"

[8005b57f-f194-44ee-88d2-a77ac4142591]
description = "only one check digit is allowed"

[fdb14c99-4cf8-43c5-b06d-eb1638eff343]
description = "X is not substituted by the value 10"

[f6294e61-7e79-46b3-977b-f48789a4945b]
description = "valid isbn without separating dashes"

Expand Down
14 changes: 14 additions & 0 deletions exercises/practice/isbn-verifier/src/test/java/IsbnVerifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,20 @@ public void xIsOnlyValidAsACheckDigit() {
assertThat(isbnVerifier.isValid("3-598-2X507-9")).isFalse();
}

@Disabled("Remove to run test")
@Test
@DisplayName("only one check digit is allowed")
public void onlyOneCheckDigitIsAllowed() {
assertThat(isbnVerifier.isValid("3-598-21508-96")).isFalse();
}

@Disabled("Remove to run test")
@Test
@DisplayName("X is not substituted by the value 10")
public void xIsNotSubstitutedByTheValue10() {
assertThat(isbnVerifier.isValid("3-598-2X507-5")).isFalse();
}

@Disabled("Remove to run test")
@Test
@DisplayName("valid isbn without separating dashes")
Expand Down