Skip to content

Add an approach to Poetry Club Door Policy #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 22, 2025
Merged

Add an approach to Poetry Club Door Policy #2630

merged 7 commits into from
May 22, 2025

Conversation

@Yrahcaz7
Copy link
Contributor

@Yrahcaz7 Yrahcaz7 commented May 21, 2025

As detailed in this forum thread, I am adding an approach to the Poetry Club Door Policy exercise.

@SleeplessByte
Copy link
Member

SleeplessByte commented May 21, 2025

/format

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

The "Format code" action has started running.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

The "Format code" action has finished running.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@Yrahcaz7 Yrahcaz7 marked this pull request as ready for review May 21, 2025 23:27
SleeplessByte
SleeplessByte approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Few nittpicks, but this is good to go.

@Yrahcaz7 @SleeplessByte
Apply suggestions from code review
908e708 
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
@SleeplessByte
Copy link
Member

SleeplessByte commented May 22, 2025

/format

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

The "Format code" action has started running.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

The "Format code" action has finished running.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte SleeplessByte reopened this May 22, 2025
@SleeplessByte SleeplessByte merged commit 384f553 into exercism:main May 22, 2025
5 checks passed
@Yrahcaz7 Yrahcaz7 deleted the patch-1 branch May 22, 2025 00:59
@SleeplessByte SleeplessByte added x:action/create Work on something from scratch x:type/content Work on content (e.g. exercises, concepts) x:module/concept-exercise Work on Concept Exercises labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees

No one assigned

Labels

x:action/create Work on something from scratch x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yrahcaz7 @SleeplessByte