Skip to content

Conversation

@SleeplessByte
Copy link
Member

Resolves #1501

@SleeplessByte SleeplessByte requested a review from Cool-Katt June 9, 2025 20:31
@github-actions

This comment was marked as off-topic.

@SleeplessByte SleeplessByte added x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) labels Jun 9, 2025
Copy link
Contributor

@Cool-Katt Cool-Katt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, are we changing the exercise from focusing on rest and spread to object destructuring? I feel like I've missed when that happened.
Nvm, I just saw the train-driver exercise, which i think replaces this one as a rest and spread exercise. Correct me if i'm wrong.

Also, does the file name of the ci proof matter, because it's exemplar,js in some cases and proof.ci.js in others?

~~~~
<!-- prettier-ignore-end -->

Want to level up Elyse her magic?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to help Elyse level up her magic?

(Idk, the original doesn't sound correct in my head)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah yours sounds good

@SleeplessByte
Copy link
Member Author

So, are we changing the exercise from focusing on rest and spread to object destructuring? I feel like I've missed when that happened.
Nvm, I just saw the train-driver exercise, which i think replaces this one as a rest and spread exercise. Correct me if i'm wrong.

Correct

Also, does the file name of the ci proof matter, because it's exemplar,js in some cases and proof.ci.js in others?

Concept exercises are exemplar.js and practice exercises are proof.ci.js

I made that choice because for concept exercises the proof should be idiomatic but this is not the case for the practice exercises. We have a few hacky "just make it pass" solutions hehe

@Cool-Katt Cool-Katt merged commit b13e967 into main Jun 10, 2025
7 checks passed
@Cool-Katt Cool-Katt deleted the concept/object-destructering branch June 10, 2025 09:21
@SleeplessByte SleeplessByte added the x:action/create Work on something from scratch label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elyses Destructered Enchantments: Add object destructering and remove rest and spread

3 participants