Skip to content

Remove nested describes to unbreak task-based testing #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

Remove nested describes to unbreak task-based testing #2686

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4567a8
Remove nested describes to unbreak task-based testing
IsaacG Jun 19, 2025
ee124a0
Format it!
SleeplessByte Jun 19, 2025
0387a0e
Update exercises/concept/freelancer-rates/freelancer-rates.spec.js
SleeplessByte Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 35 additions & 42 deletions exercises/concept/freelancer-rates/freelancer-rates.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,57 +35,50 @@ describe('day rate', () => {
});

describe('days in budget', () => {
describe('with a budget of 1280', () => {
test('at 16/hour', () => {
const actual = daysInBudget(1280, 16);
const expected = 10;
test('with a budget of 1280 at 16/hour', () => {
const actual = daysInBudget(1280, 16);
const expected = 10;

expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('at 25/hour', () => {
const actual = daysInBudget(1280, 25);
const expected = 6;
test('with a budget of 1280 at 25/hour', () => {
const actual = daysInBudget(1280, 25);
const expected = 6;

expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

describe('with a budget of 835', () => {
test('at 12/hour', () => {
const actual = daysInBudget(835, 12);
const expected = 8;
test('with a budget of 835 at 12/hour', () => {
const actual = daysInBudget(835, 12);
const expected = 8;

expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
});
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
});

describe('cost with monthly discount', () => {
describe('at 16/hour', () => {
test('for 70 days', () => {
const actual = priceWithMonthlyDiscount(16, 70, 0);
const expected = 8960;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('for 130 days with 15% discount', () => {
const actual = priceWithMonthlyDiscount(16, 130, 0.15);
const expected = 14528;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
test('at 16/hour for 70 days', () => {
const actual = priceWithMonthlyDiscount(16, 70, 0);
const expected = 8960;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('at 16/hour for 130 days with 15% discount', () => {
const actual = priceWithMonthlyDiscount(16, 130, 0.15);
const expected = 14528;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
describe('at 29.654321/hour', () => {
test('for 220 days with 11.2%', () => {
const actual = priceWithMonthlyDiscount(29.654321, 220, 0.112);
const expected = 46347;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('for 155 days with 25.47% discount', () => {
const actual = priceWithMonthlyDiscount(29.654321, 155, 0.2547);
const expected = 27467;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('at 29.654321/hour for 220 days with 11.2%', () => {
const actual = priceWithMonthlyDiscount(29.654321, 220, 0.112);
const expected = 46347;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});

test('at 29.654321/hour for 155 days with 25.47% discount', () => {
const actual = priceWithMonthlyDiscount(29.654321, 155, 0.2547);
const expected = 27467;
expect(actual).toBeCloseTo(expected, DIFFERENCE_PRECISION_IN_DIGITS);
});
});