-
-
Notifications
You must be signed in to change notification settings - Fork 645
add error-handling exercise #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
A-O-Emmanuel
wants to merge
5
commits into
exercism:main
Choose a base branch
from
A-O-Emmanuel:implement-error-handling-exercise
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
010e4ec
add error-handling exercise
A-O-Emmanuel 69a0b95
[CI] Format code
github-actions[bot] 0c70883
add github username and update proof.ci.js and error-handling.js
A-O-Emmanuel 42df9e1
Merge branch 'implement-error-handling-exercise' of https://github.co…
A-O-Emmanuel 272f673
Edit introduction and update proof.ci.js, error-handling.js, and erro…
A-O-Emmanuel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Instructions | ||
|
||
Implement various kinds of error handling and resource management. | ||
|
||
An important point of programming is how to handle errors and close resources even if errors occur. | ||
|
||
This exercise requires you to handle various errors. | ||
Because error handling is rather programming language specific you'll have to refer to the tests for your track to see what's exactly required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Error Handling | ||
|
||
In this exercise, you will implement a function called `processString` that processes a given input string with proper error handling. | ||
|
||
You will learn how to: | ||
|
||
- Check input types and throw errors for invalid inputs. | ||
- Throw errors for specific cases (e.g., empty strings). | ||
- Return the uppercase version of the string if it is valid. | ||
|
||
Your function should: | ||
|
||
- Throw a `TypeError` if input is not a string. | ||
- Throw a general `Error` if input is an empty string. | ||
- Return the uppercase form of the string 'hello'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/node_modules | ||
/bin/configlet | ||
/bin/configlet.exe | ||
/package-lock.json | ||
/yarn.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"authors": [ | ||
"A-O-Emmanuel" | ||
], | ||
"files": { | ||
"solution": [ | ||
"error-handling.js" | ||
], | ||
"test": [ | ||
"error-handling.spec.js" | ||
], | ||
"example": [ | ||
".meta/proof.ci.js" | ||
] | ||
}, | ||
"blurb": "Implement various kinds of error handling and resource management." | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
export const processString = (input) => { | ||
if (typeof input !== 'string') { | ||
throw new TypeError(); | ||
} | ||
if (input === '') { | ||
throw new Error(); | ||
} | ||
return input.toUpperCase(); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
audit=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
|
||
Copyright (c) 2021 Exercism | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = { | ||
presets: [['@exercism/babel-preset-javascript', { corejs: '3.40' }]], | ||
plugins: [], | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export const processString = (input) => { | ||
//TODO: implement this | ||
//should throw TypeError if input is not a string | ||
//should throw a general Error if input is an empty string | ||
//should return the uppercase version of the string 'hello' | ||
}; |
A-O-Emmanuel marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { describe, expect, test, xtest } from '@jest/globals'; | ||
import { processString } from './error-handling'; | ||
|
||
describe('Error Handling', () => { | ||
test('throws TypeError if input is not a string', () => { | ||
expect(() => processString(42)).toThrow(TypeError); | ||
}); | ||
|
||
xtest('throws Error message if string is empty', () => { | ||
expect(() => processString('')).toThrow(Error); | ||
}); | ||
|
||
xtest('returns uppercase string if input is valid', () => { | ||
expect(processString('hello')).toBe('HELLO'); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// @ts-check | ||
|
||
import config from '@exercism/eslint-config-javascript'; | ||
import maintainersConfig from '@exercism/eslint-config-javascript/maintainers.mjs'; | ||
|
||
import globals from 'globals'; | ||
|
||
export default [ | ||
...config, | ||
...maintainersConfig, | ||
{ | ||
files: maintainersConfig[1].files, | ||
rules: { | ||
'jest/expect-expect': ['warn', { assertFunctionNames: ['expect*'] }], | ||
}, | ||
}, | ||
{ | ||
files: ['scripts/**/*.mjs'], | ||
languageOptions: { | ||
globals: { | ||
...globals.node, | ||
}, | ||
}, | ||
}, | ||
// <<inject-rules-here>> | ||
{ | ||
ignores: [ | ||
// # Protected or generated | ||
'/.appends/**/*', | ||
'/.github/**/*', | ||
'/.vscode/**/*', | ||
|
||
// # Binaries | ||
'/bin/*', | ||
|
||
// # Configuration | ||
'/config', | ||
'/babel.config.js', | ||
|
||
// # Typings | ||
'/exercises/**/global.d.ts', | ||
'/exercises/**/env.d.ts', | ||
], | ||
}, | ||
]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module.exports = { | ||
verbose: true, | ||
projects: ['<rootDir>'], | ||
testMatch: [ | ||
'**/__tests__/**/*.[jt]s?(x)', | ||
'**/test/**/*.[jt]s?(x)', | ||
'**/?(*.)+(spec|test).[jt]s?(x)', | ||
], | ||
testPathIgnorePatterns: [ | ||
'/(?:production_)?node_modules/', | ||
'.d.ts$', | ||
'<rootDir>/test/fixtures', | ||
'<rootDir>/test/helpers', | ||
'__mocks__', | ||
], | ||
transform: { | ||
'^.+\\.[jt]sx?$': 'babel-jest', | ||
}, | ||
moduleNameMapper: { | ||
'^(\\.\\/.+)\\.js$': '$1', | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"name": "@exercism/javascript-practice-error-handling", | ||
"description": "Exercism practice exercise on error-handling", | ||
"author": "Katrina Owen", | ||
"contributors": [ | ||
"Derk-Jan Karrenbeld <[email protected]> (https://derk-jan.com)", | ||
"Tejas Bubane (https://tejasbubane.github.io/)" | ||
], | ||
"private": true, | ||
"license": "MIT", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/exercism/javascript", | ||
"directory": "exercises/practice/error-handling" | ||
}, | ||
"devDependencies": { | ||
"@exercism/babel-preset-javascript": "^0.5.1", | ||
"@exercism/eslint-config-javascript": "^0.8.1", | ||
"@jest/globals": "^29.7.0", | ||
"@types/node": "^22.15.29", | ||
"@types/shelljs": "^0.8.17", | ||
"babel-jest": "^29.7.0", | ||
"core-js": "~3.42.0", | ||
"diff": "^8.0.2", | ||
"eslint": "^9.28.0", | ||
"expect": "^29.7.0", | ||
"globals": "^16.2.0", | ||
"jest": "^29.7.0" | ||
}, | ||
"dependencies": {}, | ||
"scripts": { | ||
"lint": "corepack pnpm eslint .", | ||
"test": "corepack pnpm jest", | ||
"watch": "corepack pnpm jest --watch", | ||
"format": "corepack pnpm prettier -w ." | ||
}, | ||
"packageManager": "[email protected]" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.