Update tests bank-account #2745
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| return Promise.all(tasks); | ||
| } | ||
|
|
||
| xtest('Changing balance directly throws error', () => { |
There was a problem hiding this comment.
This test is an extra one! It isn’t listed in test.toml or in canonical-data.json on the problem-specifications repo.
It comes from the original test file.
Should we keep it, or would it be better to remove it?
There was a problem hiding this comment.
my 2 cents: The test should stay, as it's a valid use case and it's not superseded by any of the other tests
| return Promise.all(tasks); | ||
| } | ||
|
|
||
| xtest('Changing balance directly throws error', () => { |
There was a problem hiding this comment.
my 2 cents: The test should stay, as it's a valid use case and it's not superseded by any of the other tests
2 participants
No description provided.