-
-
Notifications
You must be signed in to change notification settings - Fork 55
Track docs #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track docs #547
Conversation
docs/INSTALLATION.md
Outdated
|
||
```bash | ||
opam install base core_kernel ounit qcheck | ||
git clone https://github.com/exercism/ocaml.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloning the repo and building doesn't belong here. This INSTALLATION.md
is presented to the students on the Installing OCaml locally page when they start the track. It is intended for the students, not the contributors. Students shouldn't need to do this. Contributors would most likely be looking at the README, so its to fine to leave it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I got ahead of myself. The dependencies that they should install should be the ones in the Makefile still though I assume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so. For example, they shouldn't need the yojson
for parsing JSON - none of the exercises require JSON processing. I think the original list of base core_kernel ounit qcheck
are the only ones that students need for the exercises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. I will resubmit that
I've just managed to try out your instructions for setting up OCaml and got it working in a Debian Bookworm environment 😀. Admittedly, I used It's getting late here, but I'll come back to review the changes. |
That's great. It should work for all versions >= 5.1.0. My default environment is 5.3.0 and I tested that with all versions In between. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just gone through and reviewed the changes. Comments and suggestions below 👇🏻
docs/INSTALLATION.md
Outdated
|
||
The test library is called OUnit, and some exercises additionally use the | ||
QCheck library for property-based tests. | ||
Run the script to install the dependencies required by this track: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is opam a script? I wasn't really sure ... alternatively, we could leave out the word script like this:
Run the script to install the dependencies required by this track: | |
Run the following to install the dependencies required by this track: |
docs/INSTALLATION.md
Outdated
5. Install IDE related tools (optional) | ||
|
||
The following relates to using VS Code as your code editor. Adjust accordingly. | ||
Install the OCaml language server from [here](https://github.com/ocaml/ocaml-lsp). | ||
Install the OCaml VS Code extension from [here](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform), or search for `OCaml Platform` by Ocaml Labs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the items here mainly relate to VS Code, we could mention it in the heading. For example:
5. Install IDE related tools (optional) | |
The following relates to using VS Code as your code editor. Adjust accordingly. | |
Install the OCaml language server from [here](https://github.com/ocaml/ocaml-lsp). | |
Install the OCaml VS Code extension from [here](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform), or search for `OCaml Platform` by Ocaml Labs. | |
5. Install tools in VS Code (optional) | |
If you use VS Code: | |
- Install the OCaml language server from [here](https://github.com/ocaml/ocaml-lsp). | |
- Install the OCaml VS Code extension from the [marketplace](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform), or search for `OCaml Platform` by Ocaml Labs. |
Thank you for the comments, I will adjust the text. I know you said you installed a new envionemtn with the commands I mentioned. Did you try to install a new dev environment with |
Thanks for reminding me! I forgot to try that out 😅. I just tested it and got the same package conflicts as you did:
|
Great (well not really that great). At least it means it isn't just me. This can be fixed by replacing the opam install dune ounit qcheck fpath react ppx_deriving ppx_sexp_conv yojson ocp-indent calendar core mustache ezjsonm core_unix Could you test that your enviroment works with that? This just removes With your approval, perhaps we can change this with a seperate PR? I submitted a fix to review just in case you want to test the branch first. |
Yup, I've tested this in the PR #553 and I was able to go right to generate the exercises. It looked ok to me, so I went ahead and merged that one. |
First draft of track docs update