Skip to content

Conversation

@nix-gh
Copy link
Contributor

@nix-gh nix-gh commented Sep 9, 2025

Those tests have been discussed here : https://forum.exercism.org/t/adding-tests-to-the-two-bucket-exercise/19163

There goal is to verify the solution is able to do several pour without refilling or emptying a bucket. This should catch some common pitfall when implementing it with Diophantine equations.

I added some randomly generated v4 uuid. I'm not sure if it's ok or if it should come from something else.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Sep 9, 2025
@IsaacG IsaacG reopened this Sep 9, 2025
@nix-gh nix-gh force-pushed the two-bucket-test-with-big-diff-in-size branch from 5b98808 to 017e3c1 Compare September 9, 2025 14:25
@nix-gh nix-gh force-pushed the two-bucket-test-with-big-diff-in-size branch from 017e3c1 to 72633e1 Compare September 9, 2025 14:31
@IsaacG
Copy link
Member

IsaacG commented Sep 9, 2025

I think it would be good to give maintainers at least 24 hours here to double check prior to merging.

@BethanyG
Copy link
Member

BethanyG commented Sep 9, 2025

I have yet to test these for my track, but am fine with merging them. I can always omit them if they create issues.

@nix-gh
Copy link
Contributor Author

nix-gh commented Sep 10, 2025

I have yet to test these for my track, but am fine with merging them. I can always omit them if they create issues.

Please take the time to do it, I was a bit surprised there is no automatic way to test the tests data. I guess it's not easy to put in place. So better double checking before merging in main. I paid attention but I'm human, a copy/past error can happen.

@IsaacG IsaacG merged commit 3698399 into exercism:main Sep 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants