-
-
Notifications
You must be signed in to change notification settings - Fork 557
Protein Translation: Rewrite per discussion #2570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protein Translation: Rewrite per discussion #2570
Conversation
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! My only nit is to use one sentence per line. See https://exercism.org/docs/building/markdown/markdown#h-one-sentence-per-line
tasxatzial
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"RNA sequences", "RNA strands", "RNA strings".
What's the difference? It's a little confusing. Maybe make the terminology more consistent?
kotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval pending Single Sentence Per Line (more than only a nit).
It is the accepted style as documented.
|
As far as I know, a strand would be the entire nucleotide chain. A sequence would refer to the parts being transcribed at any given moment. A RNA string likely is just a RNA sequence misidentified then. |
|
Those RNA terms might be good to discuss in a follow up. |
SleeplessByte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the suggestions by Erik, and I agree with the confusion raised by @tasxatzial, but also with @IsaacG that that should be tackled in a follow-up so this can be merged and propagated :)
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
|
Done. Thanks everyone! Review required to unblock the merge. |
...at http://forum.exercism.org/t/tweak-language-and-formatting-in-protein-translation-description-md/17005/72