Skip to content

Conversation

@FraSanga
Copy link
Contributor

@FraSanga FraSanga commented Aug 30, 2025

This PR introduces a new exercise where students must simulate the card game Beggar-my-neighbour and implement an algorithm to determine whether a given match eventually ends or falls into an infinite loop.

Here is the topic on the forum.

TO-DO:

  • All tests need to be fixed by adding the numbers as requested by Jeremy.
  • The example given needs to be fixed (it should not be a json).
  • Improve the explanation of card counting and tricks.
  • Adding smaller/simpler tests would not be a bad idea.
  • Adding Special block (sometimes called admonitions) for edge cases
  • Review

@github-actions github-actions bot closed this Aug 30, 2025
@BNAndras BNAndras reopened this Aug 30, 2025
@exercism exercism deleted a comment from github-actions bot Aug 31, 2025
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nits.

Great stuff!

FraSanga and others added 20 commits August 31, 2025 10:29
@SleeplessByte
Copy link
Member

CI Failure is unrelated:

[islendiga-app]: http://www.islendingaapp.is/information-in-english/

@IsaacG
Copy link
Member

IsaacG commented Sep 6, 2025

CI Failure is unrelated:

[islendiga-app]: http://www.islendingaapp.is/information-in-english/

See #2585

@IsaacG
Copy link
Member

IsaacG commented Sep 6, 2025

@kotp @BNAndras The instructions have changed a fair bit since your approvals. Would you be able to take another look?

@IsaacG IsaacG requested review from BNAndras and kotp September 6, 2025 17:45
@IsaacG
Copy link
Member

IsaacG commented Sep 6, 2025

@ErikSchierboom Would you mind taking a look?

@IsaacG
Copy link
Member

IsaacG commented Sep 7, 2025

FWIW here is my Python implementation which validates the current canonical data.

@ErikSchierboom
Copy link
Member

@ErikSchierboom Would you mind taking a look?

Sure!

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Anyone have any suggestions?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some potential for mood altering working wording, and clarification about the pile keeps growing. I would think that the pile is always something less than 52 cards.

@IsaacG
Copy link
Member

IsaacG commented Sep 8, 2025

This got a lot of really good feedback from quite a few people. It seems like the feedback has run out. If there's no other feedback in the next 12-24 hours, I'll go ahead and merge.

@kotp kotp self-requested a review September 8, 2025 17:46
@IsaacG IsaacG merged commit 7fc6778 into exercism:main Sep 9, 2025
7 checks passed
@FraSanga FraSanga deleted the camicia branch September 9, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants