Sync say tests
#435
Sync say tests
#435
Conversation
BNAndras
added
x:module/practice-exercise
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Closes #274 as well |
| (-> (and/c exact-nonnegative-integer? (</c 1e12)) string?) | ||
| (if (zero? number) | ||
| "zero" | ||
| (let* ([digits (string->list (number->string number))] |
There was a problem hiding this comment.
What do we gain by converting the number into lists of characters here and then turning them back into numbers in to-words? Couldn't we get the groups of three using arithmetic, e.g., with quotient/remainder? But since this method works, there is no need to change anything.
There was a problem hiding this comment.
I was trying to do things in discrete steps, but you're right. Thinking of efficiency, I think the CI should perhaps track the time taken for each example solution as an approximate estimate of how long it'd take the test runner. The example only needs to prove the test suite is solvable, but it'd be nice to know if that's within the 20 seconds available. I've had a few example solutions I wrote elsewhere that worked great on the CI but timed out when submitted. That didn't feel too great.
I rewrote the test suite to reflect the canonical tests upstream which expect a single
sayfunction. That in turn required me to update the stub and example solution.