Skip to content

initial setup and Hello World exercise#3

Open
TheRealOwenRees wants to merge 16 commits intoexercism:mainfrom
TheRealOwenRees:hello-world
Open

initial setup and Hello World exercise#3
TheRealOwenRees wants to merge 16 commits intoexercism:mainfrom
TheRealOwenRees:hello-world

Conversation

@TheRealOwenRees
Copy link

Initial commit

  • boilerplate code and Rescript setup copied from the work of tesjasbubane mentioned on the forum post

  • Testing setup in accordance to previous completed work, using Rescript-Test

  • Hello World exercise added

  • npm run ci is the command from previous work which will compile ReScript files into JS and then test those. No doubt this command will need renaming.

Copy link
Member

@BNAndras BNAndras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some notes. The main thing is to not set the track to active until we're ready to launch and have received feedback from other maintainers on the track / online editor


copy_example_or_examplar_to_solution
unskip_tests
#unskip_tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we committing to having all tests run every time? I believe we can still test.skip every test after the first one.


ln -s "${root_dir}/node_modules" "${tmp_dir}/node_modules"

copy_example_or_examplar_to_solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copy_example_or_examplar_to_solution
copy_example_or_exemplar_to_solution


required_tool jq

copy_example_or_examplar_to_solution() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copy_example_or_exemplar_to_solution() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old set of instructions. We don't need to do it right this moment, but before launch, let's make sure to have configlet sync docs and metadata for everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants