paasio: Prevent non-unwinding panic in tests#2099
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
bd42f49 to
8e6c085
Compare
7967fa3 to
ffe4607
Compare
8e6c085 to
8d48377
Compare
ellnix
left a comment
There was a problem hiding this comment.
Interesting bug and creative solution. I don't think we can set the panicked flag inside the BufWriter, although I assume that would work around this.
I think in addition to the comment explaining why this is done, we should include a link to the forum discussion.
8d48377 to
162c9bb
Compare
Done 👍 |
Related forum post:
https://forum.exercism.org/t/test-runner-fail-on-paas/19426
[no important files changed]