Conversation
Putting the clippy output in a log file is somewhat convenient for local use. But if there's a failure in CI that's difficult to reproduce locally, it only makes things harder to debug.
senekor
force-pushed
the
senekor/vwyqynookrtv
branch
from
7967fa3 to
ffe4607
Compare
ellnix
approved these changes
Sep 30, 2025
Contributor
ellnix
left a comment
ellnix
left a comment
There was a problem hiding this comment.
LGTM, looks straightforward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting the clippy output in a log file is somewhat convenient for local use. But if there's a failure in CI that's difficult to reproduce locally, it only makes things harder to debug.
The actual problem must've been that clippy used to be installed in the GitHub Actions environment by default (but not anymore), so we didn't notice that it's not explicitly requested in our workflow.