Skip to content

ci uses ubuntu-24.04 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keiravillekode
Copy link

No description provided.

@IsaacG
Copy link
Member

IsaacG commented Jul 15, 2025

The failing test is a tad concerning.

@glennj
Copy link
Contributor

glennj commented Aug 6, 2025

Test failed for rest-api - failing tests:
{
  "name": "get single user",
  "message": "Result for {\"users\":[{\"name\":\"Adam\",\"owes\":{},\"owed_by\":{},\"balance\":0},{\"name\":\"Bob\",\"owes\":{},\"owed_by\":{},\"balance\":0}]} as {\"users\":[\"Bob\"]} is {\"users\":[\"{\\\"name\\\":\\\"Bob\\\",\\\"owes\\\":{},\\\"owed_by\\\":{},\\\"balance\\\":0}\"]}, but should be {\"users\":[{\"name\":\"Bob\",\"owes\":{},\"owed_by\":{},\"balance\":0}]}"
}
what value
expected {\"users\":[{\"name\":\"Bob\",\"owes\":{},\"owed_by\":{},\"balance\":0}]}
actual {\"users\":[\"{\\\"name\\\":\\\"Bob\\\",\\\"owes\\\":{},\\\"owed_by\\\":{},\\\"balance\\\":0}\"]}

The user object is getting stringified.

What version of sqlite is provided in 22.04 versus 24.04? Would there be a difference in the JSON functionality?

@IsaacG
Copy link
Member

IsaacG commented Aug 6, 2025

22.04:

root@bce5f89d7e8e:/# sqlite3 --version
3.37.2 2022-01-06 13:25:41 872ba256cbf61d9290b571c0e6d82a20c224ca3ad82971edc46b29818d5dalt1

24.04

root@3327d1f11af3:/# sqlite3 --version
3.45.1 2024-01-30 16:01:20 e876e51a0ed5c5b3126f52e532044363a014bc594cfefa87ffb5b82257ccalt1 (64-bit)

@IsaacG
Copy link
Member

IsaacG commented Aug 6, 2025

https://www.sqlite.org/releaselog/3_45_0.html

Enhancements to the JSON SQL functions:

  • All JSON functions are rewritten to use a new internal parse tree format called JSONB. The new parse-tree format is serializable and hence can be stored in the database to avoid unnecessary re-parsing whenever the JSON value is used.
  • New versions of JSON-generating functions generate binary JSONB instead of JSON text.
  • The json_valid() function adds an optional second argument that specifies what it means for the first argument to be "well-formed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants