Skip to content

Conversation

@SaschaMann
Copy link
Contributor

No description provided.

@SaschaMann SaschaMann requested a review from iHiD February 4, 2021 23:06
@SaschaMann
Copy link
Contributor Author

with:
files: "."
config_file: ".github/markdownlint.json"
ignore_files: "analyzer-comments/*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this doesn't work: https://github.com/marketplace/actions/markdownlint-cli

I tried

"analyzer-comments/*"
"analyzer-comments/**/*"
"analyzer-comments/**"

Copy link

@wolf99 wolf99 Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried "analyzer-comments" or maybe "analyzer-comments/" ?
Looking at https://github.com/igorshubovych/markdownlint-cli, it seems like the globbing is used to reference specific files. But the CLI parameter also allows a directory to be ignored (allows file, directory or glob). The README for the link you have given mentions the same.

Have separate restricted queues for core and side exercises when importing solutions created in v1 or in Practice Mode.

### [Website] Make side-exercise mentoring opt-in:
## [Website] Make side-exercise mentoring opt-in:
Copy link

@wolf99 wolf99 Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon at end of headings are not needed.
Same for other headings with colons or other punctuation (.?!:) at the end.
Not part of this change I know, but while you're editing the line...?

Just spotted a lot of these further down this change and the pedant grammarian in me is crying 🤣

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just recalled this is still in draft; I'll stop now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants