Skip to content

[c++/atbash-cypher] Create mentoring.md #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[c++/atbash-cypher] Create mentoring.md #2331

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
350f0f2
Create mentoring.md
denisf2 Mar 17, 2024
24202e2
Update mentoring.md
denisf2 Mar 18, 2024
63364fc
Apply mentoros suggestions
denisf2 Mar 20, 2024
7c5f1d5
Delete tracks/cpp/exercises/atbash-cipher/atbash-cipher/mentoring.md
denisf2 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tracks/cpp/exercises/atbash-cipher/atbash-cipher/mentoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The atbash cipher is symmetrical that is why it is possible to use one function to encode and decode.
Copy link
Member

@IsaacG IsaacG Mar 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This doesn't follow the structure of other mentoring notes.
  • These notes are very sparse. If you'd like to tackle creating new notes, it would be nice to have them a bit more fleshed out.


Ask a student to refactor.
`Could you extract chunk splitting code and make refactoring of you code taking in account that fact?`