-
-
Notifications
You must be signed in to change notification settings - Fork 955
Add prefer_extracted_top_level_constant analyzer comment #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
52b4a06
Add prefer_extracted_top_level_constant analyzer comment to javascrip…
Steffe-Dev eaef422
Format analyzer-comments/javascript/resistor-color-duo/prefer_extract…
Steffe-Dev f3f128c
add exported method to prefer_extracted_top_level_constant in js resi…
Steffe-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
...r-comments/javascript/resistor-color-duo/prefer_extracted_top_level_constant.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # prefer extracted top level constant | ||
|
|
||
| Consider extracting the constant to the top level scope: | ||
|
|
||
| ```javascript | ||
| const %{name} = %{value} | ||
|
|
||
| // the rest of your code below it | ||
| export const decodedValue = (...) | ||
| ``` | ||
|
|
||
| Only functions, classes and constants that are `export`ed, are visible and | ||
| accessible from the outside. These constants can live in the same | ||
| file without being exposed to other code. Also, extracting constants saves memory | ||
| by avoiding repeated allocations in functions when those same constants are reused. | ||
Steffe-Dev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised, this may NOT be the function declaration the student is using. It could be many forms, including:
Ideally, we inject the function signature the student actually used here. Do you think that's something you could add? We do it in another place, where it's using the source code to extract this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion. I added it, both here and on the analyzer pr. 🙌