Changing leap (java) comments for issue #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
track/java
siebenschlaefer
left a comment
siebenschlaefer
left a comment
There was a problem hiding this comment.
I'm not involved in the Java track, I just noticed two small things.
| @@ -0,0 +1,3 @@ | |||
| # avoid redundant ternary | |||
|
|
|||
| Try returning the conditions directly instead of returning boolean literals (true and flase). | |||
There was a problem hiding this comment.
typo: flase
also, consider surrounding keywords with backticks: `true` and `false`
| @@ -0,0 +1,3 @@ | |||
| # avoid `if` statements | |||
|
|
|||
| Consider converting the if statement(s) into a single expression using logical operators (`&&`, `||`) or ternary operators. | |||
There was a problem hiding this comment.
maybe surround the "if" with backticks: `if`
Member
Author
There was a problem hiding this comment.
Thanks for catching that, really appreciate it!
Member
|
+cc @exercism/java |
kahgoh
reviewed
Apr 27, 2025
Co-authored-by: Kah Goh <[email protected]>
Member
|
+cc @exercism/guardians |
IsaacG
approved these changes
Apr 28, 2025
SleeplessByte
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked with this and addresses the issue raised on
java-analyzerrepo by @kahgoh!