Feature/ensemble map saas single task gp #669
Conversation
…com/Bizbalt/bofire into feature/EnsembleMapSaasSingleTaskGP
…ingleTaskGP' into feature/EnsembleMapSaasSingleTaskGP
…com/Bizbalt/bofire into feature/EnsembleMapSaasSingleTaskGP_v2
…com/Bizbalt/bofire into feature/EnsembleMapSaasSingleTaskGP
|
There are a few things that seems not working yet, will you investigate this or should I have a look? |
Yes, please have a look, I do not understand the failed checks and no tests failed on our machine. Maybe the new method does not accept the input parameters excactly as the comparable AdditiveMapSaasSingleTaskGP method. |
|
I will have a look at the end of the week! Best, Johannes |
jduerholt
left a comment
jduerholt
left a comment
There was a problem hiding this comment.
Hi @Bizbalt,
sorry that it took so long. Too much to do ;)
This looks overall very good! The failing tests are in my point of view not related to this PR.
Only two things needs to be adapted:
- Docstring
- And the model needs to be also registered here: This is a bit annoying, I know, but it is needed to avoid circular imports. Needs some refactoring ;)
Best,
Johannes
| return isinstance(my_type, type(ContinuousOutput)) | ||
|
|
||
| class EnsembleMapSaasSingleTaskGPSurrogate(TrainableBotorchSurrogate): | ||
| """Instantiates an ``EnsembleMapSaasSingleTaskGP``, which is a batched |
There was a problem hiding this comment.
Hmm, this docstring does not directly apply to BoFire, more to botorch, keep it concise (https://github.com/experimental-design/bofire/blob/main/bofire/data_models/surrogates/map_saas.py), state the differences to the version that we alread have (see the link) and just list the variables that a user in BoFire can actually choose.
There was a problem hiding this comment.
One can also link to the docstring from botorch.
5 participants
Motivation
This Feature was requested in Issue #650 and fullfilled at the BoFire hackathon on the 17th. of November 2025.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
The tests run analogous to the AdditiveMapSaasSingleTaskGP method, as both should return the same result.