E2524. Reimplement student_review_controller.rb#197
Open
Kii4ka wants to merge 47 commits intoexpertiza:mainfrom
Open
E2524. Reimplement student_review_controller.rb#197Kii4ka wants to merge 47 commits intoexpertiza:mainfrom
Kii4ka wants to merge 47 commits intoexpertiza:mainfrom
Conversation
Created StudentReviewService and removed MetareviewResponseMap from controller
simplify ( action_allowed? )
…overage reporting
…overage reporting
…overage reporting
wait for the MySQL service to be fully ready before proceeding with database setup
add:
- name: Wait for MySQL to be ready
run: |
while ! nc -z localhost 3306; do
echo "Waiting for MySQL..."
sleep 3
done
echo "MySQL is ready."
…tation-back-end into Katerina_tests
Katerina tests
Updated workflow
To test actions
Danger has errored[!] Invalid Generated by 🚫 Danger |
|
🚨 RSpec Tests Report |
|
🚨 RSpec Tests Report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple areas, including infrastructure setup, CI/CD improvements, controller and service additions, and configuration updates. Below is a summary of the most significant changes, grouped by theme:
Infrastructure and Configuration Updates:
.dockerignorefile to exclude unnecessary files and directories from Docker builds, improving efficiency.config/database.yml,config/database.yml.backup, andconfig/database.yml.localto include database credentials (username,password, andhost) and removed thesocketconfiguration. [1] [2] [3]config/application.rbto conditionally set the cache store to either Redis or memory, based on the presence of theCACHE_STOREenvironment variable.CI/CD Workflow Enhancements:
.github/workflows/main.ymlto include a MySQL readiness check before running database setup, ensuring the database is fully operational.CC_TEST_REPORTER_IDsecret before uploading coverage reports. [1] [2]New Controller and Service for Reviews:
Api::V1::StudentReviewControllerto handle student review-related actions, including authorization, service initialization, and error handling.StudentReviewServiceto encapsulate the business logic for managing student reviews, such as loading participant data, calculating review progress, and handling bidding redirection.Localization and Authorization Improvements:
set_localemethod inApplicationControllerto dynamically set the locale based on request parameters or theAccept-Languageheader.student_review/listinconfig/routes.rbto support the newly added controller action.Miscellaneous Updates:
docker-compose.ymlto change the MySQL user toroot, aligning with the database configuration changes.Gemfileto makesimplecov_json_formatteroptional by settingrequire: false.