Skip to content

Makes reminder comments trigger every time. Resolves #124 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MTwem wants to merge 2 commits into from
Closed

Makes reminder comments trigger every time. Resolves #124 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec6ba1
Always post assign/reminder comments; post every run. Resolves #124
MTwem Jan 4, 2026
45d4de2
Merge pull request #1 from exploreriii/main
MTwem Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/scripts/bot-issue-reminder-no-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,9 @@ echo "$ALL_ISSUES_JSON" | jq -c '.' | while read -r ISSUE_JSON; do
echo "[INFO] Assignees: $ASSIGNEES"
echo

# Check if this issue already has a reminder comment from ReminderBot
EXISTING_COMMENT=$(gh api "repos/$REPO/issues/$ISSUE/comments" \
--jq ".[] | select(.user.login == \"github-actions[bot]\") | select(.body | contains(\"ReminderBot\")) | .id" \
| head -n1)

if [ -n "$EXISTING_COMMENT" ]; then
echo "[INFO] Reminder comment already posted on this issue."
echo
continue
fi
# Previously: skip if a prior ReminderBot comment existed.
# Change behavior: always consider posting a reminder (do not skip when previous reminders exist).
echo "[INFO] Posting reminders regardless of existing ReminderBot comments."

# Get assignment time (use the last assigned event)
ASSIGN_TS=$(gh api "repos/$REPO/issues/$ISSUE/events" \
Expand Down
28 changes: 12 additions & 16 deletions .github/scripts/bots/assign-01-gfi-auto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,26 +86,22 @@ module.exports = async ({ github, context }) => {
}
);

const alreadyReminded = comments.some(c =>
c.body?.includes(ASSIGN_REMINDER_MARKER)
);

// Always post a reminder regardless of previous reminders.
console.log('[gfi-assign] Reminder presence', {
alreadyReminded,
remindersFound: comments.some(c => c.body?.includes(ASSIGN_REMINDER_MARKER)),
});

if (!alreadyReminded) {
await github.rest.issues.createComment({
owner,
repo,
issue_number: issue.number,
body:
ASSIGN_REMINDER_MARKER +
assignReminder(username, 'Good First'),
});
// Post reminder every time (do not skip when prior reminder exists)
await github.rest.issues.createComment({
owner,
repo,
issue_number: issue.number,
body:
ASSIGN_REMINDER_MARKER +
assignReminder(username, 'Good First'),
});

console.log('[gfi-assign] Posted assign reminder');
}
console.log('[gfi-assign] Posted assign reminder');
}

console.log('[gfi-assign] Exit: reminder path complete');
Expand Down