Skip to content

Conversation

@crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Nov 27, 2025

Revert b50eee8, which broke a bunch of unit tests in confection.

@honnibal said offline:

I think this was probably a mistake and shouldn’t have been pushed
It looks like part of this work I was doing on the Pydantic v2 migration that I was having trouble with

@crusaderky crusaderky changed the title Revert #b50eee8e512a90fd6b7ec845e0ee5b4535427bba Revert #b50eee8 Nov 27, 2025
@crusaderky
Copy link
Contributor Author

Python 3.10 failure fixed in next PR

@crusaderky crusaderky merged commit 281a42a into explosion:main Nov 27, 2025
21 of 30 checks passed
@crusaderky crusaderky deleted the revert-b50 branch November 27, 2025 16:23
crusaderky added a commit to crusaderky/confection that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant