Linters refresh #71
Merged
Linters refresh #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Nov 27, 2025
| run: | | ||
| python -m pip install flake8 -c requirements.txt | ||
| python -m flake8 confection --count --select=E901,E999,F821,F822,F823,W605 --show-source --statistics | ||
| python -m flake8 confection --show-source --statistics |
lysnikolaou
approved these changes
Nov 27, 2025
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM!
One thing I tend to do in these types of PRs is separate configuration changes and actual formatting changes / linting in different commits to make the review slightly easier.
| return create_model(f"{reg_name} {func_name} model", __config__=model_config, **fields) # type: ignore | ||
| return create_model( | ||
| f"{reg_name} {func_name} model", __config__=model_config, **fields | ||
| ) # type: ignore |
There was a problem hiding this comment.
I know mypy is out of scope but this type: ignore will not ignore what was being ignored before. Maybe something for when/if mypy is in scopy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade black, isort, and flake8.
Run more flake8 checks in CI.
Out of scope: mypy is quite red, both with the old version pinned by the project and the latest. Fixing all the errors it highlights woud require substantially more effort.