Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

Comments

Preventing componentWillMount renaming warning#122

Open
Karrimor wants to merge 2 commits intoexpo:masterfrom
Karrimor:master
Open

Preventing componentWillMount renaming warning#122
Karrimor wants to merge 2 commits intoexpo:masterfrom
Karrimor:master

Conversation

@Karrimor
Copy link

Added UNSAFE_ prefix to componentWillMount as quick fix to remove constant warnings and so expo-pixi will continue to work in React 17.x

Copy link
Contributor

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contribution! ❤️

That's good temporary solution, however I guess UNSAFE_componentWillMount might become deprecated in the future so we still need to figure out and fix this properly 🙂

@Karrimor
Copy link
Author

Agreed, it's absolutely a temporary fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants