Skip to content

chore: update Node.js version to test against #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sheplu wants to merge 1 commit into from
Closed

chore: update Node.js version to test against #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [18, 19, 20, 21, 22, 23]
node-version: [18, 20, 22, 24, 25]
Copy link
Member

@bjohansebas bjohansebas Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove those Node.js versions that are not LTS? In the other repositories we also keep CI running for those versions.

Suggested change
node-version: [18, 20, 22, 24, 25]
node-version: [18, 19, 20, 21, 22, 23, 24, 25]

Copy link
Contributor

@AugustinMauroy AugustinMauroy Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use this action that took semver range and generate the aray
https://github.com/ljharb/actions/tree/main/node/matrix
example https://github.com/nodejs/userland-migrations/blob/8d2de45dee99f5906acf76b434d1251acf79730f/.github/workflows/ci.yml#L46

# Node.js release schedule: https://nodejs.org/en/about/releases/

name: Node.js ${{ matrix.node-version }} - ${{matrix.os}}
Expand Down