fix relative path problem #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
force-pushed
the
test-path
branch
from
8890290 to
0da46a2
Compare
bjohansebas
force-pushed
the
test-path
branch
from
0da46a2 to
5438ccc
Compare
kjugi
reviewed
Dec 9, 2024
Member
kjugi
left a comment
kjugi
left a comment
There was a problem hiding this comment.
I have applied some changes to the code itself.
Your change with a fix for a relative path problem is still there. When I started to debug the unit tests I noticed a few more changes and decided to apply them instead of explaining what I meant in the comments. Hope you don't mind ✌️
Member
Author
|
Now there's a small issue with Windows, I'll check it later. |
bjohansebas
force-pushed
the
test-path
branch
from
063d4ee to
5d37dc6
Compare
bjohansebas
force-pushed
the
test-path
branch
from
5d37dc6 to
8bafa2f
Compare
kjugi
reviewed
Dec 11, 2024
kjugi
approved these changes
Dec 12, 2024
Member
Author
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the relative path would solve this problem with the ignore pattern
Fixes #7