-
-
Notifications
You must be signed in to change notification settings - Fork 9
chore: add .npmrc to disable package-lock #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
kjugi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand the problem described in the PR. Can you link examples or something like that? Maybe we can figure it out together
|
We don’t send the package-lock to the consumers of the package, and we shouldn’t. Dependabot will create unnecessary PRs since only we will be using it. Therefore, having Dependabot send PRs that only update the package-lock is just noise in our GitHub notifications (I already have too many, and I don’t want them to be filled with unnecessary Dependabot updates). Luckily, Dependabot runs monthly, so it’s not a big concern. However, this package won’t receive frequent PRs since it consists of codemods. Merging PRs that only update dependencies (and only modify the package-lock) creates an unnecessarily long history. Instead, we could simply delete those PRs and unnecessary commits by ignoring and preventing the creation of the package-lock. |
|
@bjohansebas To solve that problem, we can simply add |
|
I don't understand the problem. |
|
I'm not making myself clear, sorry, my English isn't very good. What I mean is that Dependabot is going to open PRs updating dependencies, most of which will be unnecessary. See #39, #37, #38,—they only update the version in the package-lock. I can merge these PRs, but every month, similar PRs will be created (only updating the version in the package-lock), which doesn't make sense and will create unnecessary history in Git. It's useful when the version in the package.json is also updated, like in #43, but most PRs will only update the versions in the package-lock, making them unnecessary PRs that can be avoided by removing the package-lock. This PR has nothing to do with the package publication. |
|
This can be changed in the dependabot config I believe. Should be set to |
Okay, with Dependabot, we don't want it to create unnecessary PRs, knowing that the package-lock file is not uploaded to npm and shouldn't be. So, we are removing the package-lock to reduce unnecessary noise.